exceptionfactory commented on a change in pull request #5650:
URL: https://github.com/apache/nifi/pull/5650#discussion_r783424809
##########
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##########
@@ -128,8 +132,7 @@ class ConfigEncryptionTool {
private static final String NEW_FLOW_PROVIDER_ARG = "newFlowProvider"
private static final String TRANSLATE_CLI_ARG = "translateCli"
- private static final String PROTECTION_SCHEME_DESC =
String.format("Selects the protection scheme for encrypted properties. " +
- "Valid values are: [%s] (default is %s)",
PropertyProtectionScheme.values().join(", "), DEFAULT_PROTECTION_SCHEME.name())
+ private static final String PROTECTION_SCHEME_DESC = "Selects the
protection scheme for encrypted properties. Default is AES_GCM"
Review comment:
That's a good question. On the one hand, based on the configured
properties, many of the possible protection schemes might not be available. A
more complex solution could attempt to drive the output based on the supported
providers information when the tool executes. Maintaining the current solution
could be done through an extension of the ProtectionSchemeResolver. The valid
values are described in Toolkit Guide documentation, but of course that is not
as convenient as writing the values in the output. Do you think keeping
something similar to the current approach is the best solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
