gresockj commented on a change in pull request #5650:
URL: https://github.com/apache/nifi/pull/5650#discussion_r783430407
##########
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##########
@@ -128,8 +132,7 @@ class ConfigEncryptionTool {
private static final String NEW_FLOW_PROVIDER_ARG = "newFlowProvider"
private static final String TRANSLATE_CLI_ARG = "translateCli"
- private static final String PROTECTION_SCHEME_DESC =
String.format("Selects the protection scheme for encrypted properties. " +
- "Valid values are: [%s] (default is %s)",
PropertyProtectionScheme.values().join(", "), DEFAULT_PROTECTION_SCHEME.name())
+ private static final String PROTECTION_SCHEME_DESC = "Selects the
protection scheme for encrypted properties. Default is AES_GCM"
Review comment:
Yes -- I see how it could be a bit misleading to list schemes that are
not technically enabled, but I think the resulting error would at least give
feedback that would allow the user to configure it if needed. I think the
benefit of having the full list in the CLI help description is worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
