exceptionfactory commented on a change in pull request #5650:
URL: https://github.com/apache/nifi/pull/5650#discussion_r783427399
##########
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/toolkit/encryptconfig/util/XmlEncryptor.groovy
##########
@@ -83,17 +83,11 @@ abstract class XmlEncryptor {
throw new IllegalStateException("Input XML is encrypted, but
decryption capability is not enabled. " +
"Usually this means a decryption password / key was
not provided to the tool.")
}
- String supportedDecryptionScheme =
decryptionProvider.getIdentifierKey()
logger.debug("Found ${encryptedNodes.size()} encrypted XML
elements. Will attempt to decrypt using the provided decryption key.")
encryptedNodes.each { node ->
logger.debug("Attempting to decrypt ${node.text()}")
- if (node.@encryption != supportedDecryptionScheme) {
Review comment:
Yes, this seemed like an unnecessary sanity check given that the
selected provider would throw an exception if it failed to decrypt the property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
