tpalfy commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1019942580
@joewitt @exceptionfactory I was thinking about avoiding code duplication using inheritance. However that would require a dependency on the _nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service_ **jar** or the _nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service-nar_ **nar**. I had the (maybe unfounded) feeling that such a dependency would be undesirable. When I looked how other similar modules were created I found no example of a similar dependency, there were code duplications instead. That's why I assumed there is a reason why we don't want such dependencies in general. Is it okay to add either the **jar** or the **nar** dependency? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
