exceptionfactory commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1020179087
Thanks for following up on this @tpalfy. Having a NAR dependency can be problematic because it could pull in the META-INF directory with the Processor definition, which would result in the attempt to register the same processor more than once. Excluding specific files from the destination NAR becomes problematic as well. It seems like the best approach would require refactoring shared code to a new module, and then depending on that module in both `nifi-dbcp-service` and `nifi-snowflake-service`. Perhaps named something like `nifi-dbcp-shared`? That module would contain the shared code, but would not include the META-INF directory. That type of approach should avoid potential issues that would result by attempting to depend on the existing DBCP JAR or NAR modules as currently defined. That will require some refactoring, but it seems like the best approach when it comes to avoiding duplication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
