exceptionfactory commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1020456025
The `nifi-dbcp-shared` would contain the shared service implementation code, but not the service definition file, so that would be the difference from the current structure. This is somewhat of an odd case since it is essentially providing a convenience class for something that can be configured using the existing controller service. Although there may not be good examples of this in the current code base, this is an opportunity to avoid unnecessary code duplication. There may be other module structure alternatives, but one way or the other, we should avoid this level of code duplication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
