mcgilman commented on code in PR #8703:
URL: https://github.com/apache/nifi/pull/8703#discussion_r1581364868
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/component-state/component-state.effects.ts:
##########
@@ -53,10 +55,12 @@ export class ComponentStateEffects {
}
})
),
- catchError((error) =>
+ catchError((errorResponse: HttpErrorResponse) =>
of(
- ComponentStateActions.componentStateApiError({
- error: error.error
+ ErrorActions.snackBarError({
Review Comment:
Should this be a banner when it happens following `clearComponentState`?
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/system-diagnostics/system-diagnostics.reducer.ts:
##########
@@ -44,15 +43,13 @@ export const systemDiagnosticsReducer = createReducer(
on(loadSystemDiagnosticsSuccess, reloadSystemDiagnosticsSuccess, (state, {
response }) => ({
...state,
- error: null,
status: 'success' as const,
loadedTimestamp:
response.systemDiagnostics.aggregateSnapshot.statsLastRefreshed,
systemDiagnostics: response.systemDiagnostics
})),
- on(systemDiagnosticsApiError, (state, { error }) => ({
+ on(systemDiagnosticsBannerError, (state) => ({
Review Comment:
Should we also be setting `status` to `error` when reported through the
snackbar?
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/system-diagnostics/system-diagnostics.effects.ts:
##########
@@ -49,13 +51,24 @@ export class SystemDiagnosticsEffects {
}
})
),
- catchError((error) =>
- of(
-
SystemDiagnosticsActions.systemDiagnosticsApiError({
- error: error.error
+ catchError((errorResponse: HttpErrorResponse) => {
+ if (request.source === 'cluster-listing') {
+ return of(
+ ErrorActions.snackBarError({
Review Comment:
Should this be a `banner` on top of the cluster page since what is failing
to load the content for the page (if they are on one of the system diagnostics
tabs)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
