mcgilman commented on code in PR #8703:
URL: https://github.com/apache/nifi/pull/8703#discussion_r1583542530
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/status-history/status-history.selectors.ts:
##########
@@ -34,3 +34,8 @@ export const selectStatusHistoryFieldDescriptors =
createSelector(
selectStatusHistory,
(state: StatusHistoryEntity) => state.statusHistory?.fieldDescriptors
);
+
+export const selectStatusHistoryStatus = createSelector(
+ selectStatusHistoryState,
+ (state: StatusHistoryState) => state.status
+);
Review Comment:
This is new in this PR and is not used.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/system-diagnostics/system-diagnostics.effects.ts:
##########
@@ -74,10 +87,12 @@ export class SystemDiagnosticsEffects {
}
})
),
- catchError((error) =>
+ catchError((errorResponse: HttpErrorResponse) =>
of(
-
SystemDiagnosticsActions.systemDiagnosticsApiError({
- error: error.error
+ ErrorActions.snackBarError({
+ error: `Failed to load System Diagnostics. -
[${
+ errorResponse.error || errorResponse.status
+ }]`
})
Review Comment:
I think this needs to be using `systemDiagnosticsSnackbarError` otherwise
the `status` stays in `loading`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
