mcgilman commented on code in PR #8703:
URL: https://github.com/apache/nifi/pull/8703#discussion_r1583284994
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/cluster/state/cluster-listing/cluster-listing.effects.ts:
##########
@@ -69,6 +63,22 @@ export class ClusterListingEffects {
)
);
+ loadClusterListingSuccess$ = createEffect(() =>
+ this.actions$.pipe(
+ ofType(ClusterListingActions.loadClusterListingSuccess),
+ concatLatestFrom(() => this.store.select(selectCurrentUser)),
Review Comment:
`concatLatestFrom` is imported from the wrong package. I also noticed that
`systemDiagnosticsService` is injected in the constructor here but is not used
anymore.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/navigation/navigation.component.ts:
##########
@@ -129,7 +129,8 @@ export class Navigation implements OnInit, OnDestroy {
this.store.dispatch(
getSystemDiagnosticsAndOpenDialog({
request: {
- nodewise: false
+ nodewise: false,
+ errorStrategy: 'banner'
Review Comment:
`errorStrategy` shouldn't be needed for `getSystemDiagnosticsAndOpenDialog`.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/system-diagnostics/index.ts:
##########
@@ -91,6 +91,7 @@ export interface SystemDiagnosticSnapshot {
export interface SystemDiagnosticsRequest {
nodewise: boolean;
+ errorStrategy: 'banner' | 'snackbar';
Review Comment:
I don't think the `errorStrategy` is needed when opening this from
`navigation`. Can we either have a different action payload for `reload` (where
`errorStrategy` is needed) or have it be optional here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
