dan-s1 commented on PR #10058: URL: https://github.com/apache/nifi/pull/10058#issuecomment-3024395748
@zhtk I am not understanding your hesitation. Isn't the copying code (i.e copying rows) from a StreamingSheet? We are not trying to call copy on a streaming object we are trying to copy from them which I thought would not touch the unsupported methods. This is what your changes have essentially done. I would assume in a streaming class this method would also not be supported. > By the way, can you briefly explain why the code doesn't work for HSSF? I know for sure that it won't help with memory usage, because format of HSSF enforces to keep the whole file content in memory. Currently SplitExcel does not support HSSF as you can see in the original code the streaming library is used which I understood supports only XSSF type files. In fact you had made the changes in `RowIterator` to only use the streaming API if the specified type was XLSX (which I believe is synonymous with XSSF). The changes you have made to use `SXSSFWorkbook` also is XSSF centric as that class only supports XSSF type files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
