zhtk commented on PR #10058: URL: https://github.com/apache/nifi/pull/10058#issuecomment-3024579340
@dan-s1, perhaps I didn't understand your proposal. What is the scope of changes you propose to move to Apache POI? Note that in code I provided method signature changes and some parts of implementation were removed (e.g. ability to shift row numbers between source and destination sheets, some copy settings). As I understood, you ask to add `copyRows(Sheet sourceSheet)` method to `SXSSFSheet` class, correct? Then the method implementation can ensure that it works correctly with SXSSFSheet destination, but it's hard to ensure that after some refactoring/changes to SXSSFSheet the method will work with parameter `sourceSheet` set to `StreamingSheet` class. The class coming from a different library, inheriting POI interfaces and implementing only subset of methods from `Sheet` interface. Does it make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
