zhtk commented on PR #10058: URL: https://github.com/apache/nifi/pull/10058#issuecomment-3032189660
@pjfanning, thanks too for detailed explanation. Fixed your comments. @exceptionfactory, moved all logic from ExcelRowCopier back to processor. @dan-s1, accordingly to the response received in mailing list (https://lists.apache.org/thread/o8fj0685pf115mnbzhk8rssscrtp8syr), the method was made to be similar to https://github.com/pjfanning/excel-streaming-reader/blob/main/src/test/java/com/github/pjfanning/xlsx/CopyToSXSSFUtil.java I have adjusted SXSSFWorkbook to use shared strings to ensure compatibility with all clients. Tests with file described in the Jira ticket didn't show significant changes in memory usage. If we need to, we can optimise it later and take a look at https://github.com/pjfanning/poi-shared-strings. From my perspective, we can merge PR, it should give the same functionality as code before changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
