zhtk commented on code in PR #10058:
URL: https://github.com/apache/nifi/pull/10058#discussion_r2184916010


##########
nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/processors/excel/SplitExcel.java:
##########
@@ -230,6 +226,29 @@ public void onTrigger(ProcessContext context, 
ProcessSession session) throws Pro
         session.transfer(flowFileSplits, REL_SPLIT);
     }
 
+    public static int copyRows(final Sheet originalSheet, final Sheet 
destinationSheet) {

Review Comment:
   Good catch, fixed



##########
nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/processors/excel/SplitExcel.java:
##########
@@ -230,6 +226,29 @@ public void onTrigger(ProcessContext context, 
ProcessSession session) throws Pro
         session.transfer(flowFileSplits, REL_SPLIT);
     }
 
+    public static int copyRows(final Sheet originalSheet, final Sheet 
destinationSheet) {
+        final CellCopyContext cellCopyContext = new CellCopyContext();
+        int rowCount = 0;
+
+        for (Row sourceRow : originalSheet) {
+            final Row destinationRow = 
destinationSheet.createRow(sourceRow.getRowNum());
+            destinationRow.setHeight(sourceRow.getHeight());
+
+            for (final Cell sourceCell : sourceRow) {
+                final Cell destCell = 
destinationRow.createCell(sourceCell.getColumnIndex());
+                CellUtil.copyCell(sourceCell, destCell, CELL_COPY_POLICY, 
cellCopyContext);
+            }
+
+            ++rowCount;
+        }
+
+        for (CellRangeAddress sourceRegion : originalSheet.getMergedRegions()) 
{

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to