zhtk commented on code in PR #10058:
URL: https://github.com/apache/nifi/pull/10058#discussion_r2185029548
##########
nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/processors/excel/SplitExcel.java:
##########
@@ -127,7 +130,7 @@ public class SplitExcel extends AbstractProcessor {
.condenseRows(CellCopyPolicy.DEFAULT_CONDENSE_ROWS_POLICY)
.copyHyperlink(CellCopyPolicy.DEFAULT_COPY_HYPERLINK_POLICY)
.mergeHyperlink(CellCopyPolicy.DEFAULT_MERGE_HYPERLINK_POLICY)
- .mergedRegions(CellCopyPolicy.DEFAULT_COPY_MERGED_REGIONS_POLICY)
+ .mergedRegions(false) // NOTE: set to false because of the
explicit merge region handling in the copyRows method.
Review Comment:
It works, I just disabled it based on [this
comment](https://github.com/apache/poi/blob/67320b6453d0d81fec13d9cf3cf4f1d1ba3ac73a/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java#L3003):
> final CellCopyPolicy options = new CellCopyPolicy(policy);
> // avoid O(N^2) performance scanning through all regions for each
row
> // merged regions will be copied after all the rows have been copied
> options.setCopyMergedRegions(false);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
