takraj commented on PR #10102: URL: https://github.com/apache/nifi/pull/10102#issuecomment-3095838494
> ... on initial consideration, creating an extra empty FlowFile does not sound like a good approach, as it could disrupt existing flow expectations. @exceptionfactory Could you open up a little, in what sense would it distrupt the existing flow expectations? We would also put it behind a switch, so `ExecuteSQL` and `ExecuteSQLRecord` would then both have a new property, like 'Add EOF Flow File' or 'Add Sentinel Flow File', with true/false settings, by default set to false. So unless it is intentionally turned on, these processors would behave the original way. I have some concerns about the current approach, because it is a bit complicated with this Flow File delaying + migrating between sessions solution. Adding an extra Flow File is simpler, and simpler is usually better from maintenance perspective. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
