exceptionfactory commented on PR #10102:
URL: https://github.com/apache/nifi/pull/10102#issuecomment-3103717171

   > Uhm. It doesn't, and it shouldn't. Currently this attribute is always 
added to the last Flow File, regardless to the `Output Batch Size` and `Max 
Rows Per Flow File` settings. I can scope it down to only add, if _both_ of 
these have a value, if you think it is reasonable.
   > 
   > Currently the description of the attribute itself says:
   > 
   > > This attribute is added to the very last created FlowFile, to indicate 
end of results. This is primarily serving the downstream processors, when 
'Output Batch Size' is set, in which case no other information is available 
about the total number of fragments created from a single result set.
   
   Thanks for pointing that out, I was read an earlier comment as thinking that 
this should be changed.
   
   Regarding the `executesql` prefix, I see what you mean about some other 
attributes already using it, although there is a mixture of values.
   
   Taking a second look, however, now I'm question whether this change is 
necessary at all. The Processor already writes `fragment.count` and 
`fragment.index` in this scenario, so simply comparing those values indicates 
the presence of the last FlowFile in a batch.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to