exceptionfactory commented on PR #10102: URL: https://github.com/apache/nifi/pull/10102#issuecomment-3098307187
> > ... on initial consideration, creating an extra empty FlowFile does not sound like a good approach, as it could disrupt existing flow expectations. > > @exceptionfactory Could you open up a little, in what sense would it distrupt the existing flow expectations? > > We would also put it behind a switch, so `ExecuteSQL` and `ExecuteSQLRecord` would then both have a new property, like 'Add EOF Flow File' or 'Add Sentinel Flow File', with true/false settings, by default set to false. So unless it is intentionally turned on, these processors would behave the original way. > > I have some concerns about the current approach, because it is a bit complicated with this Flow File delaying + migrating between sessions solution. Adding an extra Flow File is simpler, and simpler is usually better from maintenance perspective. What do you think? @takraj Writing an empty FlowFile could be disruptive for existing flows that expect to receive FlowFiles containing at least one result. Some flow designs may be built to handle empty FlowFiles, others may not. Adding a new property could be one way to implement this feature in a compatible way, so that could be considered. However, introducing new properties adds some level of complexity for the flow designer, which is more important to consider than code complexity. With that being said, transferring FlowFiles between ProcessSessions raises some implementation questions. I need to take a closer look at the implementation details, but at the moment it is not clear why it is necessary to create more than one session. Is it not possible to set the attribute on the last of Result Set FlowFiles before transferring? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
