szaszm commented on code in PR #2045:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2045#discussion_r3111855319


##########
core-framework/include/controllers/ProxyConfiguration.h:
##########
@@ -18,16 +17,18 @@
 #pragma once
 
 #include <string>
-#include <cstdint>
+#include <optional>
 
+#include "minifi-cpp/controllers/ProxyConfigurationServiceInterface.h"
 
-namespace org::apache::nifi::minifi::aws {
+namespace org::apache::nifi::minifi::controllers {
 
-struct ProxyOptions {
-  std::string host;
-  uint32_t port = 0;
-  std::string username;
-  std::string password;
+struct ProxyConfiguration {
+  ProxyType proxy_type;
+  std::string proxy_host;
+  std::optional<uint16_t> proxy_port;
+  std::optional<std::string> proxy_user;
+  std::optional<std::string> proxy_password;

Review Comment:
   I'd make proxy_port a raw uint16_t, it's always going to be set anyway, or 
we can use 0 as a default value if need be. Also let's move the username + 
password into a separate struct with not optional string fields, and have an 
optional<ProxyCredentials> here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to