szaszm commented on code in PR #2045:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2045#discussion_r3130923021
##########
extensions/azure/tests/ListAzureDataLakeStorageTests.cpp:
##########
@@ -256,4 +256,27 @@ TEST_CASE_METHOD(ListAzureDataLakeStorageTestsFixture,
"Both SAS Token and Stora
REQUIRE_THROWS_AS(test_controller_.runSession(plan_, true),
minifi::Exception);
}
+TEST_CASE_METHOD(ListAzureDataLakeStorageTestsFixture, "List data lake storage
files using proxy", "[azureDataLakeStorageParameters]") {
+ auto proxy_configuration_service =
plan_->addController("ProxyConfigurationService", "ProxyConfigurationService");
+ plan_->setProperty(proxy_configuration_service, "Proxy Server Host",
"https://host";);
+ plan_->setProperty(proxy_configuration_service, "Proxy Server Port", "1234");
+ plan_->setProperty(proxy_configuration_service, "Proxy User Name",
"username");
+ plan_->setProperty(proxy_configuration_service, "Proxy User Password",
"password");
+ plan_->setProperty(proxy_configuration_service, "Proxy Type", "HTTPS");
Review Comment:
HTTPS is no longer supported, we should change it to HTTP
##########
extensions/azure/storage/DataLakeStorageClient.h:
##########
@@ -39,6 +41,7 @@ struct AzureDataLakeStorageParameters {
std::string file_system_name;
std::string directory_name;
std::optional<uint64_t> number_of_retries;
+ std::optional<minifi::controllers::ProxyConfiguration> proxy_configuration;
Review Comment:
We can remove the optional member now
##########
extensions/azure/storage/AzureDataLakeStorageClient.cpp:
##########
@@ -35,13 +35,24 @@ AzureDataLakeStorageClient::AzureDataLakeStorageClient() {
utils::AzureSdkLogger::initialize();
}
-std::unique_ptr<Azure::Storage::Files::DataLake::DataLakeFileSystemClient>
AzureDataLakeStorageClient::createClient(
- const AzureStorageCredentials& credentials, const std::string&
file_system_name, std::optional<uint64_t> number_of_retries) {
+std::unique_ptr<Azure::Storage::Files::DataLake::DataLakeFileSystemClient>
AzureDataLakeStorageClient::createClient(const AzureStorageCredentials&
credentials,
+ const std::string& file_system_name, std::optional<uint64_t>
number_of_retries, const
std::optional<minifi::controllers::ProxyConfiguration>& proxy_configuration) {
Review Comment:
An optional non-owning reference can be more simply represented as a pointer
```suggestion
const std::string& file_system_name, std::optional<uint64_t>
number_of_retries, minifi::controllers::ProxyConfiguration* const
proxy_configuration) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
