lordgamez commented on code in PR #2045:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2045#discussion_r3155140496
##########
extensions/azure/storage/DataLakeStorageClient.h:
##########
@@ -39,6 +41,7 @@ struct AzureDataLakeStorageParameters {
std::string file_system_name;
std::string directory_name;
std::optional<uint64_t> number_of_retries;
+ std::optional<minifi::controllers::ProxyConfiguration> proxy_configuration;
Review Comment:
Removed optional in
https://github.com/apache/nifi-minifi-cpp/pull/2045/commits/29da0bdc1203b7bf69d6813c1d8ebeec2f9763f1
##########
core-framework/include/controllers/ProxyConfiguration.h:
##########
@@ -18,16 +17,18 @@
#pragma once
#include <string>
-#include <cstdint>
+#include <optional>
+#include "minifi-cpp/controllers/ProxyConfigurationServiceInterface.h"
-namespace org::apache::nifi::minifi::aws {
+namespace org::apache::nifi::minifi::controllers {
-struct ProxyOptions {
- std::string host;
- uint32_t port = 0;
- std::string username;
- std::string password;
+struct ProxyConfiguration {
+ ProxyType proxy_type;
+ std::string proxy_host;
+ std::optional<uint16_t> proxy_port;
+ std::optional<std::string> proxy_user;
+ std::optional<std::string> proxy_password;
Review Comment:
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/2045/commits/29da0bdc1203b7bf69d6813c1d8ebeec2f9763f1
##########
extensions/azure/tests/ListAzureDataLakeStorageTests.cpp:
##########
@@ -256,4 +256,27 @@ TEST_CASE_METHOD(ListAzureDataLakeStorageTestsFixture,
"Both SAS Token and Stora
REQUIRE_THROWS_AS(test_controller_.runSession(plan_, true),
minifi::Exception);
}
+TEST_CASE_METHOD(ListAzureDataLakeStorageTestsFixture, "List data lake storage
files using proxy", "[azureDataLakeStorageParameters]") {
+ auto proxy_configuration_service =
plan_->addController("ProxyConfigurationService", "ProxyConfigurationService");
+ plan_->setProperty(proxy_configuration_service, "Proxy Server Host",
"https://host";);
+ plan_->setProperty(proxy_configuration_service, "Proxy Server Port", "1234");
+ plan_->setProperty(proxy_configuration_service, "Proxy User Name",
"username");
+ plan_->setProperty(proxy_configuration_service, "Proxy User Password",
"password");
+ plan_->setProperty(proxy_configuration_service, "Proxy Type", "HTTPS");
Review Comment:
Removed in
https://github.com/apache/nifi-minifi-cpp/pull/2045/commits/29da0bdc1203b7bf69d6813c1d8ebeec2f9763f1
##########
extensions/azure/storage/AzureDataLakeStorageClient.cpp:
##########
@@ -35,13 +35,24 @@ AzureDataLakeStorageClient::AzureDataLakeStorageClient() {
utils::AzureSdkLogger::initialize();
}
-std::unique_ptr<Azure::Storage::Files::DataLake::DataLakeFileSystemClient>
AzureDataLakeStorageClient::createClient(
- const AzureStorageCredentials& credentials, const std::string&
file_system_name, std::optional<uint64_t> number_of_retries) {
+std::unique_ptr<Azure::Storage::Files::DataLake::DataLakeFileSystemClient>
AzureDataLakeStorageClient::createClient(const AzureStorageCredentials&
credentials,
+ const std::string& file_system_name, std::optional<uint64_t>
number_of_retries, const
std::optional<minifi::controllers::ProxyConfiguration>& proxy_configuration) {
Review Comment:
Removed optional so it is a const ref now in
https://github.com/apache/nifi-minifi-cpp/pull/2045/commits/29da0bdc1203b7bf69d6813c1d8ebeec2f9763f1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
