adamdebreceni commented on code in PR #2195:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2195#discussion_r3528276611
##########
extensions/rocksdb-repos/ProvenanceRepository.cpp:
##########
@@ -73,28 +73,30 @@ bool ProvenanceRepository::initialize(const
std::shared_ptr<org::apache::nifi::m
return true;
}
-bool
ProvenanceRepository::getElements(std::vector<std::shared_ptr<core::SerializableComponent>>
&records, size_t &max_size) {
+std::vector<std::shared_ptr<core::SerializableComponent>>
ProvenanceRepository::getElements(size_t max_size) {
+ if (max_size == 0) {
+ return {};
+ }
auto opendb = db_->open();
if (!opendb) {
- return false;
+ return {};
}
Review Comment:
throwing exception instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
