adamdebreceni commented on code in PR #2195:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2195#discussion_r3559424107
##########
libminifi/src/provenance/Provenance.cpp:
##########
@@ -577,7 +576,7 @@ void ProvenanceReporterImpl::fetch(const core::FlowFile&
flow_file, const std::s
}
std::shared_ptr<ProvenanceEventRecord> ProvenanceEventRecord::create() {
- return std::make_shared<ProvenanceEventRecordImpl>();
+ return
std::make_shared<ProvenanceEventRecordImpl>(ProvenanceEventType::CLONE,
utils::Identifier{}, "");
Review Comment:
this create is only used to generate an "empty" instance before reading into
it from the repository, I removed the default ctor, why I picked CLONE I don't
remember, should we go for CREATE or add a new value UNKNOWN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
