szaszm commented on code in PR #2195:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2195#discussion_r3559009488
##########
libminifi/src/provenance/Provenance.cpp:
##########
@@ -577,7 +576,7 @@ void ProvenanceReporterImpl::fetch(const core::FlowFile&
flow_file, const std::s
}
std::shared_ptr<ProvenanceEventRecord> ProvenanceEventRecord::create() {
- return std::make_shared<ProvenanceEventRecordImpl>();
+ return
std::make_shared<ProvenanceEventRecordImpl>(ProvenanceEventType::CLONE,
utils::Identifier{}, "");
Review Comment:
why do we default to a clone event now? clone only happens when multiple
connections stem from the same relationship
##########
libminifi/src/provenance/Provenance.cpp:
##########
@@ -509,7 +509,6 @@ void ProvenanceReporterImpl::clone(const core::FlowFile&
parent, const core::Flo
if (event) {
event->addChildFlowFile(child);
- event->addParentFlowFile(parent);
Review Comment:
Is this intentional? What happened here? Is it a bugfix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
