Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126457339
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void parse_url(std::string &url, std::string &host, int &port,
std::string &protocol) {
--- End diff --
Sure, I think documentation of the YAML format is a good thing to have, and
probably also a method comment on the interface for HTTPUtils for future
developers to know what format the method expects to be passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
