[GitHub] nifi-minifi-cpp pull request #114: site2site port negotiation

[kevdoran]

Github user kevdoran commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126458724
  
    --- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
    @@ -150,6 +194,87 @@ void 
RemoteProcessorGroupPort::onTrigger(core::ProcessContext *context, core::Pr
       return;
     }
     
    +void RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo() {
    +  if (this->host_.empty() || this->port_ == -1 || this->protocol_.empty())
    +      return;
    +
    +  std::string fullUrl = this->protocol_ + this->host_ + ":" + 
std::to_string(this->port_) + "/nifi-api/controller/";
    --- End diff --
    
    Thanks for posting that @benqiu2016. I learned something new about the NiFI 
REST API :).
    
    Are you planning to add support for default protocol ports?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---