[
https://issues.apache.org/jira/browse/NIFI-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653775#comment-16653775
]
ASF GitHub Bot commented on NIFI-5629:
--------------------------------------
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3033#discussion_r225997511
--- Diff:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
---
@@ -1422,10 +1424,15 @@ public String
getDefaultBackPressureDataSizeThreshold() {
public static NiFiProperties createBasicNiFiProperties(final String
propertiesFilePath, final Map<String, String> additionalProperties) {
final Map<String, String> addProps = (additionalProperties ==
null) ? Collections.EMPTY_MAP : additionalProperties;
final Properties properties = new Properties();
- final String nfPropertiesFilePath = (propertiesFilePath == null)
+ String nfPropertiesFilePath = (propertiesFilePath == null)
? System.getProperty(NiFiProperties.PROPERTIES_FILE_PATH)
: propertiesFilePath;
if (nfPropertiesFilePath != null) {
+ try {
--- End diff --
This sounds like it could be a legitimate bug, but it would need to be
submitted separately as it's not related to fixing `GetFile`. I run on Windows,
but I don't have spaces in the path, maybe switch to a new path with no spaces
for now?
> GetFile becomes slow listing vast directories
> ---------------------------------------------
>
> Key: NIFI-5629
> URL: https://issues.apache.org/jira/browse/NIFI-5629
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.6.0
> Reporter: Adam
> Priority: Minor
>
> GetFile repeatedly lists entire directories before applying batching, meaning
> for vast directories it spends a long time listing directories.
>
> Pull request to follow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
