[
https://issues.apache.org/jira/browse/NIFI-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655232#comment-16655232
]
ASF GitHub Bot commented on NIFI-5629:
--------------------------------------
Github user adyoun2 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3033#discussion_r226305582
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFile.java
---
@@ -270,6 +280,9 @@ private FileFilter createFileFilter(final
ProcessContext context) {
return new FileFilter() {
@Override
public boolean accept(final File file) {
+ if (file.isDirectory()) {
+ return false;
--- End diff --
If you look at the performListing, the filter is applied after the walk,
with no feedback mechanism, so the additional filter just prevents Directories
being returned as entities for GetFile to process.
> GetFile becomes slow listing vast directories
> ---------------------------------------------
>
> Key: NIFI-5629
> URL: https://issues.apache.org/jira/browse/NIFI-5629
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.6.0
> Reporter: Adam
> Priority: Minor
>
> GetFile repeatedly lists entire directories before applying batching, meaning
> for vast directories it spends a long time listing directories.
>
> Pull request to follow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
