[ 
https://issues.apache.org/jira/browse/NIFI-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655193#comment-16655193
 ] 

ASF GitHub Bot commented on NIFI-5629:
--------------------------------------

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3033#discussion_r226292672
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFile.java
 ---
    @@ -270,6 +280,9 @@ private FileFilter createFileFilter(final 
ProcessContext context) {
             return new FileFilter() {
                 @Override
                 public boolean accept(final File file) {
    +                if (file.isDirectory()) {
    +                    return false;
    --- End diff --
    
    does filtering work differently with the streams?  I ask because we want to 
be able to support the same depth/recursive searches and this filter seems like 
it would stop at dir level.


> GetFile becomes slow listing vast directories
> ---------------------------------------------
>
>                 Key: NIFI-5629
>                 URL: https://issues.apache.org/jira/browse/NIFI-5629
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.6.0
>            Reporter: Adam
>            Priority: Minor
>
> GetFile repeatedly lists entire directories before applying batching, meaning 
> for vast directories it spends a long time listing directories.
>  
> Pull request to follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to