bakaid commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r347933155
########## File path: nanofi/CMakeLists.txt ########## @@ -23,32 +23,67 @@ IF(POLICY CMP0048) CMAKE_POLICY(SET CMP0048 OLD) ENDIF(POLICY CMP0048) -include_directories(include) -include_directories(../libminifi/include ../thirdparty/cron ../thirdparty/spdlog-20170710/include) -include_directories(../thirdparty/ut) +include(ExternalProject) + +if(MSVC) + set(CBOR_RESTRICT_SPECIFIER "") +elseif(APPLE) + set(CBOR_RESTRICT_SPECIFIER "restrict") +else() + set(CBOR_RESTRICT_SPECIFIER "__restrict__") +endif() + +ExternalProject_Add( + libcbor-external + GIT_REPOSITORY "https://github.com/PJK/libcbor.git"; + GIT_TAG "82512d851205fbc7f65d96a0b4a8e1bad2e4f3c6" Review comment: I dislike not using released versions of third parties, but I see that there has been a lot of commits on master since the last release, so this could be an exception. Please comment this here and create an issue to update this to a released version when they do release one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
