bakaid commented on a change in pull request #674: Minificpp 1007 - ECU C2
integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r347927366
##########
File path: CMakeLists.txt
##########
@@ -469,7 +467,7 @@ if (ENABLE_ALL OR ENABLE_GPS)
createExtension(GPS-EXTENSION "GPS EXTENSIONS" "Enables LibGPS
Functionality and the GetGPS processor." "extensions/gps"
"${TEST_DIR}/gps-tests")
endif()
-option(ENABLE_COAP "Enables the CoAP extension." OFF)
+option(ENABLE_COAP "Enables the CoAP extension." ON)
Review comment:
This is fine for testing, but otherwise I don't think this should be enabled
by default, especially until we can get it working on Windows.
As I understand we only set extensions to default ON which we are pretty
sure the majority of our users would need. I am not sure CoAP fits this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
