bakaid commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r348018141
########## File path: nanofi/CMakeLists.txt ########## @@ -23,32 +23,67 @@ IF(POLICY CMP0048) CMAKE_POLICY(SET CMP0048 OLD) ENDIF(POLICY CMP0048) -include_directories(include) -include_directories(../libminifi/include ../thirdparty/cron ../thirdparty/spdlog-20170710/include) -include_directories(../thirdparty/ut) +include(ExternalProject) + +if(MSVC) + set(CBOR_RESTRICT_SPECIFIER "") +elseif(APPLE) + set(CBOR_RESTRICT_SPECIFIER "restrict") +else() + set(CBOR_RESTRICT_SPECIFIER "__restrict__") +endif() + +ExternalProject_Add( + libcbor-external Review comment: What are we using CBOR for? I see that it is being used for encoding C2 protocol payloads, but as far as I know our CoAP C2 payload is a custom format, not CBOR. What have you tested this with? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
