szaszm commented on a change in pull request #741: MINIFICPP-1139 Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/741#discussion_r386381465
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -271,19 +280,88 @@ void ConsumeWindowsEventLog::onTrigger(const
std::shared_ptr<core::ProcessContex
return;
}
- const auto flowFileCount = processQueue(session);
+ struct TimeDiff {
+ auto operator()() const {
Review comment:
Since the scope is local and we want to be about to reliably print the
duration as milliseconds, I suggest using `uint64_t` instead of `auto` for the
return type and avoid casting at the call sites.
I can also live with wrapping the call sites in `uint64_t{ timeDiff() }`,
but I prefer an explicit return type for the sake of easy logging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
