szaszm commented on a change in pull request #741: MINIFICPP-1139 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/741#discussion_r386555753
########## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ########## @@ -271,19 +280,88 @@ void ConsumeWindowsEventLog::onTrigger(const std::shared_ptr<core::ProcessContex return; } - const auto flowFileCount = processQueue(session); + struct TimeDiff { + auto operator()() const { + return std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::steady_clock::now() - time_).count(); + } + const decltype(std::chrono::steady_clock::now()) time_ = std::chrono::steady_clock::now(); + }; + + const auto commitAndSaveBookmark = [&] (const std::wstring& bookmarkXml) { + const TimeDiff timeDiff; + session->commit(); + logger_->log_debug("processQueue commit took %" PRIu64 " ms", (uint64_t)timeDiff()); Review comment: Shouldn't be the case since you've changed the function to return `int64_t` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services