szaszm commented on a change in pull request #741: MINIFICPP-1139 Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/741#discussion_r386539946
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -271,19 +280,88 @@ void ConsumeWindowsEventLog::onTrigger(const
std::shared_ptr<core::ProcessContex
return;
}
- const auto flowFileCount = processQueue(session);
+ struct TimeDiff {
+ auto operator()() const {
Review comment:
This suggests that the underlying type of `milliseconds` is a signed type
and a signed -> unsigned conversion is narrowing. Narrowing conversions are not
allowed with direct/copy list-initialization.
I was wrong when suggesting `uint64_t`, because the underlying type is a
signed integer type. Try `int64_t`, that will most likely work. The standard
only specifies "signed integer type of at least 45 bits".
https://en.cppreference.com/w/cpp/chrono/duration
Please keep the list initialization to prevent lossy conversion in the
future if the underlying type changed to a wider one, like `int128_t`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
