szaszm commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r431852482
########## File path: libminifi/test/script-tests/ExecutePythonProcessorTests.cpp ########## @@ -0,0 +1,276 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#define CATCH_CONFIG_MAIN + +#include <memory> +#include <string> +#include <set> + +#include "../TestBase.h" + +#include "processors/GetFile.h" +#include "python/ExecutePythonProcessor.h" +#include "processors/LogAttribute.h" +#include "processors/PutFile.h" +#include "utils/file/FileUtils.h" + +namespace { + +#include <unistd.h> +#define GetCurrentDir getcwd + +std::string GetCurrentWorkingDir(void) { + char buff[FILENAME_MAX]; + GetCurrentDir(buff, FILENAME_MAX); + std::string current_working_dir(buff); + return current_working_dir; +} + +class ExecutePythonProcessorTestBase { + public: + ExecutePythonProcessorTestBase() : + logTestController_(LogTestController::getInstance()), + logger_(logging::LoggerFactory<org::apache::nifi::minifi::python::processors::ExecutePythonProcessor>::getLogger()) { + reInitialize(); + } + virtual ~ExecutePythonProcessorTestBase() { + logTestController_.reset(); + logTestController_.setDebug<TestPlan>(); + logTestController_.setDebug<minifi::python::processors::ExecutePythonProcessor>(); + logTestController_.setDebug<minifi::processors::PutFile>(); + logTestController_.setDebug<minifi::processors::PutFile::ReadCallback>(); + } + + protected: + void reInitialize() { + testController_.reset(new TestController()); + plan_ = testController_->createPlan(); + } + + std::string createTempDir() { + char dirtemplate[] = "/tmp/gt.XXXXXX"; + std::string temp_dir = testController_->createTempDirectory(dirtemplate); + REQUIRE(!temp_dir.empty()); + struct stat buffer; + REQUIRE(-1 != stat(temp_dir.c_str(), &buffer)); + REQUIRE(S_ISDIR(buffer.st_mode)); + return temp_dir; + } + + std::string putFileToDir(const std::string& dir_path, const std::string& file_name, const std::string& content) { + std::string file_path(dir_path + utils::file::FileUtils::get_separator() + file_name); + std::ofstream out_file(file_path); + if (out_file.is_open()) { + out_file << content; + out_file.close(); + } + return file_path; + } + + std::string createTempDirWithFile(const std::string& file_name, const std::string& content) { + std::string temp_dir = createTempDir(); + putFileToDir(temp_dir, file_name, content); + return temp_dir; + } + + std::string getFileContent(const std::string& file_name) { + std::ifstream file_handle(file_name); + REQUIRE(file_handle.is_open()); + const std::string file_content{ (std::istreambuf_iterator<char>(file_handle)), (std::istreambuf_iterator<char>())}; + file_handle.close(); + return file_content; + } + + std::string getScriptFullPath(const std::string& script_file_name) { + return SCRIPT_FILES_DIRECTORY + utils::file::FileUtils::get_separator() + script_file_name; + } + + const std::string TEST_FILE_NAME{ "test_file.txt" }; + const std::string TEST_FILE_CONTENT{ "Test text\n" }; + const std::string SCRIPT_FILES_DIRECTORY{ "test_scripts" }; Review comment: How does making them `static` decrease readability? If you mean the added `static` keyword increasing the line length, I think the added information of shared constant objects balances that. An alternative is extracting them from the class and putting them in an anonymous namespace, keeping the lines short and the scope limited to the translation unit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
