tysonnorris commented on a change in pull request #3211: implement
ContainerFactory.cpuShare to fix #3110
URL:
https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r163115299
##########
File path:
common/scala/src/main/scala/whisk/core/containerpool/ContainerFactory.scala
##########
@@ -44,6 +44,26 @@ trait ContainerFactory {
/** cleanup any remaining Containers; should block until complete; should
ONLY be run at startup/shutdown */
def cleanup(): Unit
+
Review comment:
This comes directly from the "old" ContainerPool:
https://github.com/apache/incubator-openwhisk/blob/e47cc71bcd73ebb3da352eeadcc4236630680e92/core/invoker/src/main/scala/whisk/core/container/ContainerPool.scala#L826-L844
which was deleted in
https://github.com/apache/incubator-openwhisk/commit/10fae73e15cf886bb3ad892e659b15a28cc4c80b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
