tysonnorris commented on a change in pull request #3211: implement
ContainerFactory.cpuShare to fix #3110
URL:
https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r163627239
##########
File path: ansible/roles/invoker/tasks/deploy.yml
##########
@@ -173,8 +173,8 @@
{% for item in (invoker_container_network_dns_servers |
default()).split(' ') %}
-e
CONFIG_whisk_containerFactory_containerArgs_dnsServers_{{loop.index0}}={{ item
}}
{% endfor %}
- -e INVOKER_NUMCORE='{{ invoker.numcore }}'
- -e INVOKER_CORESHARE='{{ invoker.coreshare }}'
+ -e CONFIG_whisk_containerFactory_containerArgs_numCore='{{
invoker.numcore }}'
+ -e CONFIG_whisk_containerFactory_containerArgs_coreShare='{{
invoker.coreshare }}'
Review comment:
I'm not sure why - these are used primarily to set the `--cpushares` flag
for docker run; it is from that perspective that the container pool also uses
it to define "maximumContainers" (to define the pool size).
FWIW in the future, I will be creating a PR to isolate these 2 items
(cpushare vs maximumContainers) , since it does not make sense for
cluster-aware deployments where maximumContainers value can fluctuate
dynamically, and is not correlated to only the setting used for `--cpushares`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
