[
https://issues.apache.org/jira/browse/ORC-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969431#comment-14969431
]
ASF GitHub Bot commented on ORC-32:
-----------------------------------
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/11
ORC-32. Fix warnings under MacOS.
This patch fixes a couple of MacOS warnings.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-32
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit c56908de9ae4543c30c47dfda582951b9b365cd7
Author: Owen O'Malley <[email protected]>
Date: 2015-10-22T16:46:14Z
ORC-32. Fix warnings under MacOS.
----
> Warnings under new version of xcode on MacOS.
> ---------------------------------------------
>
> Key: ORC-32
> URL: https://issues.apache.org/jira/browse/ORC-32
> Project: Orc
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
>
> The error on the build is:
> {code}
> [ 82%] Building CXX object c++/src/CMakeFiles/orc.dir/Reader.cc.o
> In file included from /Users/owen/work/code/orc/c++/src/Reader.cc:29:
> In file included from
> /Users/owen/work/code/orc/c++/src/wrap/coded-stream-wrapper.h:28:
> /Users/owen/work/code/orc/c++/libs/protobuf-2.6.0/src/google/protobuf/io/coded_stream.h:110:9:
> error:
> macro name is a reserved identifier [-Werror,-Wreserved-id-macro]
> #define GOOGLE_PROTOBUF_IO_CODED_STREAM_H__
> ^
> /Users/owen/work/code/orc/c++/src/Reader.cc:1074:48: error: implicit
> conversion
> changes signedness: 'long long' to 'uint64_t' (aka 'unsigned long long')
> [-Werror,-Wsign-conversion]
> selectType(schema->getSubtype(*columnId-1));
> ~~~~~~ ~~~~~~~~~^~
> /Users/owen/work/code/orc/c++/src/Reader.cc:1083:26: error: implicit
> conversion
> changes signedness: 'int64_t' (aka 'long long') to 'size_type'
> (aka 'unsigned long') [-Werror,-Wsign-conversion]
> if (!selectedColumns[type.getColumnId()]) {
> ~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~
> /Users/owen/work/code/orc/c++/src/Reader.cc:1084:23: error: implicit
> conversion
> changes signedness: 'int64_t' (aka 'long long') to 'size_type'
> (aka 'unsigned long') [-Werror,-Wsign-conversion]
> selectedColumns[type.getColumnId()] = true;
> ~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~
> 4 errors generated.
> make[2]: *** [c++/src/CMakeFiles/orc.dir/Reader.cc.o] Error 1
> make[1]: *** [c++/src/CMakeFiles/orc.dir/all] Error 2
> make: *** [all] Error 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
