[
https://issues.apache.org/jira/browse/ORC-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969485#comment-14969485
]
Hadoop QA commented on ORC-32:
------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 00s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 00s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} CMakeLists.txt {color} | {color:green}
0m 03s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 51s
{color} | {color:red} src in master failed. {color} |
| {color:green}+1{color} | {color:green} CMakeLists.txt {color} | {color:green}
0m 03s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 19s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 19s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
00s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 01s
{color} | {color:green} src in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 2m 22s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | ORC-32 |
| GITHUB PR | https://github.com/apache/orc/pull/11 |
| Optional Tests | asflicense compile unit cc |
| uname | Darwin aw-mbp-work.local 13.4.0 Darwin Kernel Version 13.4.0: Wed Mar
18 16:20:14 PDT 2015; root:xnu-2422.115.14~1/RELEASE_X86_64 x86_64 |
| Build tool | cmake |
| Personality | /Users/aw/Src/aw-github/yetus/dev-support/personality/orc.sh |
| git revision | master / eecd701 |
| Default Java | 1.7.0_79 |
| compile |
https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/artifact/patchprocess/branch-compile-c++_src.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/testReport/ |
| Powered by | Apache Yetus http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/console |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/console |
This message was automatically generated.
> Warnings under new version of xcode on MacOS.
> ---------------------------------------------
>
> Key: ORC-32
> URL: https://issues.apache.org/jira/browse/ORC-32
> Project: Orc
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
>
> The error on the build is:
> {code}
> [ 82%] Building CXX object c++/src/CMakeFiles/orc.dir/Reader.cc.o
> In file included from /Users/owen/work/code/orc/c++/src/Reader.cc:29:
> In file included from
> /Users/owen/work/code/orc/c++/src/wrap/coded-stream-wrapper.h:28:
> /Users/owen/work/code/orc/c++/libs/protobuf-2.6.0/src/google/protobuf/io/coded_stream.h:110:9:
> error:
> macro name is a reserved identifier [-Werror,-Wreserved-id-macro]
> #define GOOGLE_PROTOBUF_IO_CODED_STREAM_H__
> ^
> /Users/owen/work/code/orc/c++/src/Reader.cc:1074:48: error: implicit
> conversion
> changes signedness: 'long long' to 'uint64_t' (aka 'unsigned long long')
> [-Werror,-Wsign-conversion]
> selectType(schema->getSubtype(*columnId-1));
> ~~~~~~ ~~~~~~~~~^~
> /Users/owen/work/code/orc/c++/src/Reader.cc:1083:26: error: implicit
> conversion
> changes signedness: 'int64_t' (aka 'long long') to 'size_type'
> (aka 'unsigned long') [-Werror,-Wsign-conversion]
> if (!selectedColumns[type.getColumnId()]) {
> ~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~
> /Users/owen/work/code/orc/c++/src/Reader.cc:1084:23: error: implicit
> conversion
> changes signedness: 'int64_t' (aka 'long long') to 'size_type'
> (aka 'unsigned long') [-Werror,-Wsign-conversion]
> selectedColumns[type.getColumnId()] = true;
> ~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~
> 4 errors generated.
> make[2]: *** [c++/src/CMakeFiles/orc.dir/Reader.cc.o] Error 1
> make[1]: *** [c++/src/CMakeFiles/orc.dir/all] Error 2
> make: *** [all] Error 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
