[
https://issues.apache.org/jira/browse/ORC-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969499#comment-14969499
]
Hadoop QA commented on ORC-32:
------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:red}-1{color} | {color:red} CMakeLists.txt {color} | {color:red} 0m 0s
{color} | {color:red} src in master failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 0s
{color} | {color:red} src in master failed. {color} |
| {color:red}-1{color} | {color:red} CMakeLists.txt {color} | {color:red} 0m 0s
{color} | {color:red} src in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 0s
{color} | {color:red} src in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 0s {color} |
{color:red} src in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 0s {color} |
{color:red} src in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 6s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | ORC-32 |
| GITHUB PR | https://github.com/apache/orc/pull/11 |
| Optional Tests | asflicense compile unit cc |
| uname | Linux ubuntu 3.16.0-51-generic #69~14.04.1-Ubuntu SMP Wed Oct 7
15:32:41 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | cmake |
| Personality | /home/ubuntu/Src/yetus/dev-support/personality/orc.sh |
| git revision | master / eecd701 |
| Default Java | 1.8.0_45 |
| CMakeLists.txt | artifact/patchprocess/branch-CMakeLists.txt-c++_src.txt |
| compile | artifact/patchprocess/branch-compile-c++_src.txt |
| CMakeLists.txt | artifact/patchprocess/patch-CMakeLists.txt-c++_src.txt |
| compile | artifact/patchprocess/patch-compile-c++_src.txt |
| cc | artifact/patchprocess/patch-compile-c++_src.txt |
| unit | artifact/patchprocess/patch-test-c++_src.txt |
| Test Results | testReport/ |
| Max memory used | 47MB |
| Powered by | Apache Yetus http://yetus.apache.org |
| Console output | console |
| Console output | console |
This message was automatically generated.
> Warnings under new version of xcode on MacOS.
> ---------------------------------------------
>
> Key: ORC-32
> URL: https://issues.apache.org/jira/browse/ORC-32
> Project: Orc
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
>
> The error on the build is:
> {code}
> [ 82%] Building CXX object c++/src/CMakeFiles/orc.dir/Reader.cc.o
> In file included from /Users/owen/work/code/orc/c++/src/Reader.cc:29:
> In file included from
> /Users/owen/work/code/orc/c++/src/wrap/coded-stream-wrapper.h:28:
> /Users/owen/work/code/orc/c++/libs/protobuf-2.6.0/src/google/protobuf/io/coded_stream.h:110:9:
> error:
> macro name is a reserved identifier [-Werror,-Wreserved-id-macro]
> #define GOOGLE_PROTOBUF_IO_CODED_STREAM_H__
> ^
> /Users/owen/work/code/orc/c++/src/Reader.cc:1074:48: error: implicit
> conversion
> changes signedness: 'long long' to 'uint64_t' (aka 'unsigned long long')
> [-Werror,-Wsign-conversion]
> selectType(schema->getSubtype(*columnId-1));
> ~~~~~~ ~~~~~~~~~^~
> /Users/owen/work/code/orc/c++/src/Reader.cc:1083:26: error: implicit
> conversion
> changes signedness: 'int64_t' (aka 'long long') to 'size_type'
> (aka 'unsigned long') [-Werror,-Wsign-conversion]
> if (!selectedColumns[type.getColumnId()]) {
> ~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~
> /Users/owen/work/code/orc/c++/src/Reader.cc:1084:23: error: implicit
> conversion
> changes signedness: 'int64_t' (aka 'long long') to 'size_type'
> (aka 'unsigned long') [-Werror,-Wsign-conversion]
> selectedColumns[type.getColumnId()] = true;
> ~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~
> 4 errors generated.
> make[2]: *** [c++/src/CMakeFiles/orc.dir/Reader.cc.o] Error 1
> make[1]: *** [c++/src/CMakeFiles/orc.dir/all] Error 2
> make: *** [all] Error 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
