[ 
https://issues.apache.org/jira/browse/ORC-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994705#comment-14994705
 ] 

ASF GitHub Bot commented on ORC-21:
-----------------------------------

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/12#discussion_r44199545
  
    --- Diff: c++/include/orc/Reader.hh ---
    @@ -709,6 +709,16 @@ namespace orc {
          * @return a string of bytes with the file tail
          */
         virtual std::string getSerializedFileTail() const = 0;
    +
    +    /**
    +     * Estimate an upper bound on heap memory allocation by the Reader
    +     * based on the information in the file footer.
    +     * The bound is less tight if only few columns are read or compression 
is used.
    +     * @param stripeIx index of the stripe to be read (if not specified,
    +    * all stripes are considered).
    +     * @return upper bound on memory use
    +     */
    +    virtual uint64_t memoryUse(int stripeIx=-1) = 0;
    --- End diff --
    
    Please use getMemoryUse().


> Add functionality to estimate memory footprint
> ----------------------------------------------
>
>                 Key: ORC-21
>                 URL: https://issues.apache.org/jira/browse/ORC-21
>             Project: Orc
>          Issue Type: Task
>            Reporter: Aliaksei Sandryhaila
>            Assignee: Aliaksei Sandryhaila
>
> ORC library allocates multiple large buffers to read and materialize ORC 
> files. For stability of applications that use the library, it may be 
> desirable to have an estimate (preferably, a tight upper bound) of a memory 
> footprint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to