[
https://issues.apache.org/jira/browse/ORC-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996640#comment-14996640
]
ASF GitHub Bot commented on ORC-21:
-----------------------------------
Github user asandryh commented on a diff in the pull request:
https://github.com/apache/orc/pull/12#discussion_r44282151
--- Diff: c++/src/Reader.cc ---
@@ -1070,9 +1071,8 @@ namespace orc {
columnId != included.end(); ++columnId) {
if (*columnId == 0) {
selectType(*(schema.get()));
- } else if (*columnId <=
- static_cast<int64_t>(schema->getSubtypeCount())) {
- selectType(schema->getSubtype(static_cast<uint64_t>(*columnId-1)));
+ } else if (*columnId <=
static_cast<int64_t>(schema->getSubtypeCount())) {
+ selectType(schema->getSubtype(*columnId-1));
--- End diff --
Sorry, that's my mistake. Will restore the cast.
> Add functionality to estimate memory footprint
> ----------------------------------------------
>
> Key: ORC-21
> URL: https://issues.apache.org/jira/browse/ORC-21
> Project: Orc
> Issue Type: Task
> Reporter: Aliaksei Sandryhaila
> Assignee: Aliaksei Sandryhaila
>
> ORC library allocates multiple large buffers to read and materialize ORC
> files. For stability of applications that use the library, it may be
> desirable to have an estimate (preferably, a tight upper bound) of a memory
> footprint.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
