[
https://issues.apache.org/jira/browse/ORC-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996637#comment-14996637
]
ASF GitHub Bot commented on ORC-21:
-----------------------------------
Github user asandryh commented on a diff in the pull request:
https://github.com/apache/orc/pull/12#discussion_r44281983
--- Diff: c++/src/Reader.cc ---
@@ -1061,7 +1063,6 @@ namespace orc {
schema = convertType(footer->types(0), *footer);
schema->assignIds(0);
- previousRow = (std::numeric_limits<uint64_t>::max)();
--- End diff --
Why? In the code immediately above (around lines 1055-1060) we already set
previousRow.
This line is a left-over from a commit I made months ago when I implemented
ReaderImpl::seekToRow() method. I forgot to remove it. I discovered it recently
while testing because it conflicts with the logic of startNextStripe() and
seekToRow() methods.
> Add functionality to estimate memory footprint
> ----------------------------------------------
>
> Key: ORC-21
> URL: https://issues.apache.org/jira/browse/ORC-21
> Project: Orc
> Issue Type: Task
> Reporter: Aliaksei Sandryhaila
> Assignee: Aliaksei Sandryhaila
>
> ORC library allocates multiple large buffers to read and materialize ORC
> files. For stability of applications that use the library, it may be
> desirable to have an estimate (preferably, a tight upper bound) of a memory
> footprint.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
