[
https://issues.apache.org/jira/browse/ORC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007205#comment-16007205
]
ASF GitHub Bot commented on ORC-184:
------------------------------------
Github user wgtmac commented on the issue:
https://github.com/apache/orc/pull/120
@omalley @majetideepak @xndai
As I am waiting for [PR of ORC-185](https://github.com/apache/orc/pull/116)
being resolved, I haven't added all functions that we have implemented for
column statistics to avoid huge effort for refactoring later. In this PR, I
just followed the style of current code base which puts function declaration in
the class ColumnStatistics and implements them in every ColumnStatisticsImpl
class and it contains a lot of copying and pasting duplicate code (e.g. in
c++/src/Statistics.hh). Actually in our internal implementation, we put the
implementation of functions like hasNull(), getNumberOfValues(), increase(),
merge(), reset(), etc. into the base class **ColumnStatistics**. What are your
thoughts?
> [C++] Refactor ColumnStatistics classes for writer
> --------------------------------------------------
>
> Key: ORC-184
> URL: https://issues.apache.org/jira/browse/ORC-184
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> 1. Add setter functions to ColumnStatistics.
> 2. Refactor ColumnStatistics to reduce duplicate code.
> 3. Add more functions in Int128 and Decimal classes for
> DecimalColumnStatistics.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
