[
https://issues.apache.org/jira/browse/ORC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007249#comment-16007249
]
ASF GitHub Bot commented on ORC-184:
------------------------------------
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/120
I am strongly for rebasing this on top of ORC-185.
1) Exposing the functions you mentioned in the public API is bad design.
2) ORC-185 adds templates, which will further reduce code duplication.
> [C++] Refactor ColumnStatistics classes for writer
> --------------------------------------------------
>
> Key: ORC-184
> URL: https://issues.apache.org/jira/browse/ORC-184
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> 1. Add setter functions to ColumnStatistics.
> 2. Refactor ColumnStatistics to reduce duplicate code.
> 3. Add more functions in Int128 and Decimal classes for
> DecimalColumnStatistics.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
