[
https://issues.apache.org/jira/browse/ORC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008859#comment-16008859
]
ASF GitHub Bot commented on ORC-184:
------------------------------------
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/120
I see your concern now.
My idea is to directly use InternalIntegerStatisticsImpl from ORC-185
inside the IntegerColumnWriter. If we use the existing
IntegerColumnStatisticsImpl, then we need to duplicate all the new methods
being introduced.
I think if I add a base class to the InternalIntegerStatisticsImpl in
ORC-185, your problem should be solved.
> [C++] Refactor ColumnStatistics classes for writer
> --------------------------------------------------
>
> Key: ORC-184
> URL: https://issues.apache.org/jira/browse/ORC-184
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> 1. Add setter functions to ColumnStatistics.
> 2. Refactor ColumnStatistics to reduce duplicate code.
> 3. Add more functions in Int128 and Decimal classes for
> DecimalColumnStatistics.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
