[
https://issues.apache.org/jira/browse/ORC-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463993#comment-16463993
]
ASF GitHub Bot commented on ORC-334:
------------------------------------
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r186114158
--- Diff: c++/test/CreateTestFiles.cc ---
@@ -31,8 +31,8 @@
void writeCustomOrcFile(const std::string& filename,
const orc::proto::Metadata& metadata,
const orc::proto::Footer& footer,
- const std::vector<uint>& version,
- uint writerVersion) {
+ const std::vector<unsigned>& version,
--- End diff --
We generally prefer to use explicitly sized types, so uint64_t or uint32_t
would be better.
> Add AppVeyor support for integration on windows
> ------------------------------------------------
>
> Key: ORC-334
> URL: https://issues.apache.org/jira/browse/ORC-334
> Project: ORC
> Issue Type: Improvement
> Reporter: Deepak Majeti
> Assignee: rip.nsk
> Priority: Major
>
> Like Travis CI, we must integrate AppVeyor for windows testing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
