[
https://issues.apache.org/jira/browse/ORC-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466204#comment-16466204
]
ASF GitHub Bot commented on ORC-334:
------------------------------------
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r186487106
--- Diff: c++/src/Timezone.cc ---
@@ -710,7 +710,11 @@ namespace orc {
* Get the local timezone.
*/
const Timezone& getLocalTimezone() {
+#ifdef _MSC_VER
+ return getTimezoneByName("UTC");
--- End diff --
http://unicode.org/cldr/data/common/supplemental/windowsZones.xml - here is
a mapping of windows <=> *nix time zones,
and here - https://github.com/google/cctz - "timezone" library which
probably is a best choice (BTW https://github.com/google/cctz/issues/53).
Anyway, it is non trivial work which I think does not related to orc
directly.
I believe it should be customer decision how to pass/extract timestamps
from orc library and any timezone conversions should be done on customer side.
> Add AppVeyor support for integration on windows
> ------------------------------------------------
>
> Key: ORC-334
> URL: https://issues.apache.org/jira/browse/ORC-334
> Project: ORC
> Issue Type: Improvement
> Reporter: Deepak Majeti
> Assignee: rip.nsk
> Priority: Major
>
> Like Travis CI, we must integrate AppVeyor for windows testing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
