[
https://issues.apache.org/jira/browse/ORC-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466101#comment-16466101
]
ASF GitHub Bot commented on ORC-334:
------------------------------------
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r186474701
--- Diff: c++/src/Timezone.cc ---
@@ -710,7 +710,11 @@ namespace orc {
* Get the local timezone.
*/
const Timezone& getLocalTimezone() {
+#ifdef _MSC_VER
+ return getTimezoneByName("UTC");
--- End diff --
Because there isn't a direct windows equivalent.
Here is what Java writes about it-
https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/time-zone002.html
There is a registry setting, but it uses a non-standard set of names *doh*.
The easiest way would be to create a Java jar and run that to determine the
local timezone.
> Add AppVeyor support for integration on windows
> ------------------------------------------------
>
> Key: ORC-334
> URL: https://issues.apache.org/jira/browse/ORC-334
> Project: ORC
> Issue Type: Improvement
> Reporter: Deepak Majeti
> Assignee: rip.nsk
> Priority: Major
>
> Like Travis CI, we must integrate AppVeyor for windows testing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
