[
https://issues.apache.org/jira/browse/ORC-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474067#comment-16474067
]
ASF GitHub Bot commented on ORC-334:
------------------------------------
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r187922554
--- Diff: c++/src/Timezone.cc ---
@@ -710,7 +710,11 @@ namespace orc {
* Get the local timezone.
*/
const Timezone& getLocalTimezone() {
+#ifdef _MSC_VER
+ return getTimezoneByName("UTC");
--- End diff --
I also think that it is better to leave the conversion to the
client/customer. We should ideally change the conversion for Nix* systems but
cannot due to backward compatibility. We should be able to converge both Java
and C++ timestamps in ORC 2.0.
For Windows, since this is the first official build support, we should be
okay to use "UTC" and document this behavior.
I will merge this PR end of today if there are no objections.
> Add AppVeyor support for integration on windows
> ------------------------------------------------
>
> Key: ORC-334
> URL: https://issues.apache.org/jira/browse/ORC-334
> Project: ORC
> Issue Type: Improvement
> Reporter: Deepak Majeti
> Assignee: rip.nsk
> Priority: Major
>
> Like Travis CI, we must integrate AppVeyor for windows testing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
